[FEAT]: Implement an array sorting script #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @coxmars kindly review :) |
|
Hi @martinvibes, can you add a .tool-versions file with the Scarb and Starknet foundry versions you are using? |
|
@coxmars i have added it sir |
coxmars
requested changes
Jan 25, 2025
|
Alright sir on it |
|
hello @coxmars i have written tests for them and all tests are passing :) |
coxmars
approved these changes
Jan 25, 2025
There was a problem hiding this comment.
Local verification done, all good. Ready for second review. @danielcdz 🎯
danielcdz
reviewed
Jan 26, 2025
|
hello @danielcdz i have implemented required change 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Title
[FEAT]: Implement Sorting Algorithms
🛠️ Issue
Closes #105
📖 Description
This PR implements sorting algorithms to provide efficient array sorting capabilities. The implementation includes:
Created interface.cairo defining Sortable and SortableVec traits for consistent sorting interfaces
Implemented QuickSort algorithm with optimized pivot selection
Added Alexandria data structures as a dependency for vector operations
Structured the code in a modular way with separate files for interface and implementation
Fixed compilation issues and imports
Added proper error handling for edge cases (empty arrays, single elements)
🖼️ Screenshots
N/A - Implementation is code-only
📝 Additional Notes
The implementation supports both array and vector-based sorting
The code is prepared for future additions of other sorting algorithms
Tested with various input sizes and types
All files include proper documentation and type annotations